[OptRed] Do not assert on reductions after 3D dot ops #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triton supports 3D dot operations and intel#2518 enables them. Avoid assertions when this pass finds reductions of 3D tensors. Signed-off-by: Victor Perez <[email protected]>
sommerlukas
approved these changes
Oct 30, 2024
Contributor
Author
|
This was overseen in #2266 as this wasn't enabled back then |
etiotto
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triton supports 3D dot operations and #2518 enables using them with
DpasEncodingAttrencoding. Avoid assertions when this pass finds reductions of 3D tensors.